Fix i18n _get_default_locale_path #204
Open
+26
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangillet
force-pushed
the
fix-get-default-locale-path
branch
from
af19aaf
to
ff870da
Compare
Fixes python-humanize#105 Use importlib.resources available since Python 3.9 to find the location of the locale folder containing the translations.
dangillet
force-pushed
the
fix-get-default-locale-path
branch
from
ff870da
to
9627694
Compare
|
I tried to use The tests cover when |
hugovk
reviewed
Oct 1, 2024
There was a problem hiding this comment.
Thanks for this!
Let's do some tuning to speed up with lazy imports, which can be important for CLIs where you want a quick response time.
Using https://github.com/nschloe/tuna we can visualise the import times:
python -m pip install tuna
python -c "import humanize" && python -X importtime -c "import humanize" 2> import.log && tuna import.log
Here's main:
Here's this PR:
With the suggestions:
| return None | ||
|
|
||
| with importlib.resources.as_file(importlib.resources.files(package)) as pkg: |
There was a problem hiding this comment.
Suggested change
| with importlib.resources.as_file(importlib.resources.files(package)) as pkg: | |
| import importlib.resources | |
| with importlib.resources.as_file(importlib.resources.files(package)) as pkg: |
Comment on lines
+6
to
9
| import importlib.resources | ||
| import os | ||
| import pathlib | ||
| from threading import local |
There was a problem hiding this comment.
Suggested change
| import importlib.resources | |
| import os | |
| import pathlib | |
| from threading import local | |
| from threading import local | |
| from typing import TYPE_CHECKING | |
| if TYPE_CHECKING: | |
| import os | |
| import pathlib |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #105
Changes proposed in this pull request:
importlib.resourcesavailable since Python 3.9 to find the location of the locale folder containing the translations.